feat: dynamic clientId Initialization#61
Conversation
|
Thanks @zuhno this is a brilliant work, and im really happy about this PR 💪 it looks really good as i checked on surface |
kasvith
left a comment
There was a problem hiding this comment.
im going through the code little bit
|
@kasvith Please let me know if there are any parts that need to be revised. |
|
Sure, i didnt have much time lately to focus on the project |
refactor: applied early return to 'isClientIdValid'
There was a problem hiding this comment.
lets rename this as src/store.ts
There was a problem hiding this comment.
@kasvith
yes, the changes have been made as follows:
- identified the similar structure of states and constants and relocated them to
src/store.tsandsrc/constant.ts, respectively. - converted functions from expressions to declarations to ensure consistency with the existing code style.
- added detailed jsdoc comments to the
setGoogleClientIdmethod to improve maintainability and provide clear usage instructions.
|
hi @zuhno made a comment |
style: align with code style guidelines
|
im adding this to the v3 milestone |
|
I have checked this. I'll check the support for this feature in nuxt. |
|
@zuhno we already have a nuxt module, it needs a rewrite with newer nuxt kit once this is merged we can work on that |
|
i have checked the related repository and will follow up on the merge status. thanks. |
|
Now all looks great, i will check this out locally and then we are good to go |
Hi :)
setGoogleClientId, which operates by changing the global ref value.GoogleSignInButtonis called.I am very happy to contribute to this project. Please let me know if there are any suggestions for improvements in the folder structure or functionality.