Get rid of lineage-sdk #52
Open
erfanoabdi wants to merge 2 commits into
Open
Conversation
Member
erfanoabdi
commented
May 24, 2026
erfanoabdi
commented
- Move services to framework repo
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Waydroid integration by adding the frameworks/waydroid project to the manifest and applying patches to the Android base. These changes transition the codebase from the lineageos.waydroid namespace to id.waydro.waydroid and integrate the Waydroid framework into the build system and SystemServer. Feedback was provided to correct a trace name in SystemServer.java that appears to be a leftover from a different project.
| reportWtf("Making " + externalServer + " ready", e); | ||
| } | ||
|
|
||
| + t.traceBegin("startLMODroidServices"); |
There was a problem hiding this comment.
The trace name startLMODroidServices appears to be a leftover from a copy-paste from LMODroid. It should be updated to reflect the Waydroid service being started.
+ t.traceBegin("startWaydroidServices");
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.