sensorfw-core: sync datatypes header changes from latest SensorFW#11
Open
peat-psuwit wants to merge 2 commits into
Open
sensorfw-core: sync datatypes header changes from latest SensorFW#11peat-psuwit wants to merge 2 commits into
peat-psuwit wants to merge 2 commits into
Conversation
SensorFW 0.14.0 "silently" change the wire format over unix socket, exposing the change over the in-tree, Qt-ridden headers only [^1]. This change pulls in the latest changes in datatypes/ headers from SensorFW 0.15.1, transforming it in the same way it was before (quint64 -> uint64_t, remove Qt-ism). In practice, the most important change is in `genericdata.h`. One other header has a miscellaneous change, but I've decided to include them for completeness. [^1]: sailfishos/sensorfw@532fc4c
Because backwards-incompatible nature of the wire format change, enforce built package to be used on SensorFW >= 0.14.0 only.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the debian/control file to require libsensorfw-qt5-plugins version 0.14.0 or higher. It also changes the TimedXyzData coordinate types from int to float and updates an include path in touchdata.h. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SensorFW 0.14.0 "silently" change the wire format over unix socket,
exposing the change over the in-tree, Qt-ridden headers only 1.
This change pulls in the latest changes in datatypes/ headers from
SensorFW 0.15.1, transforming it in the same way it was before (quint64
-> uint64_t, remove Qt-ism). In practice, the most important change is
in
genericdata.h. One other header has a miscellaneous change, butI've decided to include them for completeness.
Footnotes
https://github.com/sailfishos/sensorfw/commit/532fc4cf91bc6291d5b4828348dd65c7c938308c ↩