Bug: fix NPE during assignment change #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r2d2li
reviewed
Apr 6, 2021
Dockerfile
Outdated
| @@ -0,0 +1,16 @@ | |||
| FROM adoptopenjdk/openjdk8 | |||
Collaborator
There was a problem hiding this comment.
I would create a "docker" directory and store this file inside that directory.
For the JDK, you could also use this image: "wayfair/maven-openjdk8:0.9.2"
| }); | ||
| _committingCheckpoint = checkpoint; | ||
| } | ||
| recordJdbcTaskMetrics(arrayRecords, METRIC_NUMBER_OF_ROWS_PROCESSED); |
Collaborator
There was a problem hiding this comment.
Move to line 26 and add an else statement
| this.poll(); | ||
| } catch (Exception e) { | ||
| _logger.warn("Failed poll. {}", e); | ||
| _logger.warn("Failed poll. id: {}, url: {}, topic: {}", |
Collaborator
There was a problem hiding this comment.
Should be "error" instead of "warm"?
Collaborator
There was a problem hiding this comment.
Add data stream name into the logger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes: