feat: Media dropdown add hours to duration format if media is longer than 1 hour#165
Open
5ila5 wants to merge 1 commit intowayle-rs:masterfrom
Open
feat: Media dropdown add hours to duration format if media is longer than 1 hour#1655ila5 wants to merge 1 commit intowayle-rs:masterfrom
5ila5 wants to merge 1 commit intowayle-rs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Media Dropdown shows there digit minute count instead of usual
hh:mm:ssformat if the media is longer than one hour.This is a simple fix:
hh:mm:ssmm:ss.I added this simple fix and an appropriate test case
One could add a setting for this, but I'd think the majority of people would prefer it this way
For Some reason I cannot attach an image right now (no clue why) but it looks like expected. For my test YouTube video shows
3:26:55 / 5:21:07 instead of 212:26 / 321:07