removed dependency on sass #193
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has been open for a while.. is anyone still interested in removing the sass dependency? |
Author
|
I'd still like to see the sass dependency removed. And it looks like others agree based on the other threads addressing this topic. The Travis CI seems to be missing some environment variables causing it to fail - which I don't believe I have access to. (I certainly didn't add the need for any environment variables in my pull request) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently wanted to add this useful gem to a project built with less instead of sass. Since the css for this gem is minimal I converted the sass to standard css which ultimately led to a break even on the lines of code. To increase usability I recommend merging this change into master.