Added Payroll::PayRun#456
Open
vladiim wants to merge 3 commits into
Open
Conversation
added 3 commits
November 1, 2018 10:14
…Xeroizer::PayrollApplication instance
CloCkWeRX
reviewed
Nov 11, 2018
| record :PayRun | ||
|
|
||
| def initialize(application) | ||
| application.instance_variable_set("@xero_url", "https://api.xero.com/payroll.xro/1.0") |
Collaborator
There was a problem hiding this comment.
I'm not sure we should be doing this here
Collaborator
|
Looks pretty good at first glance - you might be interested though in our payroll branch which appears to have the models already - https://github.com/waynerobinson/xeroizer/blob/payroll/lib/xeroizer/models/payroll/pay_run.rb |
Collaborator
|
I bit the bullet and merged some of our payroll branch to master. If you resolve the conflicts and give it a go; I can merge this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows :get requests for the Payroll::PayRun api
Feedback probably required - this is my first open source PR.