-
Notifications
You must be signed in to change notification settings - Fork 5
FEATURE | Hero - Carousel | Swiper.js demo #813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
@breakdancingcat before I mark this as "Ready for review", I'd like to walk through this together. |
cfb8b34 to
904170e
Compare
|
This is simply a proof-of-concept. If we decide to go with Swiper, we'll want to actually build out it's required HTML markup instead of how I'm injecting it via JavaScript right now in the demo component |
|
Thanks, Kyle! We'll keep this open and revisit it again soon. |
chrispelzer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talked with you about this in person and the benefits are great!
I'm wondering if our slideout and mediabox need the same treatment. I haven't looked into those packages and what's available these days but I know they've been somewhat like Flickity coming along for the ride.
Reason for change
Relevant links
Reminders
Demo