-
Notifications
You must be signed in to change notification settings - Fork 5
Feature | Tailwind v3 -> v4, Laravel Mix -> Vite #839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
chrispelzer
wants to merge
20
commits into
develop
Choose a base branch
from
feature/tailwind-4
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd82d69 to
86b3552
Compare
86b3552 to
c62500c
Compare
c62500c to
32118ef
Compare
32118ef to
1092a13
Compare
367174c to
fe829f1
Compare
e6728b6 to
7f1d62d
Compare
7f1d62d to
02268f0
Compare
02268f0 to
456190e
Compare
456190e to
7485b58
Compare
7485b58 to
ae81ac4
Compare
ae81ac4 to
5550a9b
Compare
fd8ecf7 to
63655db
Compare
63655db to
865b2da
Compare
…/sass-lang.com/documentation/cli/migrator/) with the command `sass-migrator module --migrate-deps resources/scss/main.scss`
… `!optional` ``` [vite:css] [sass] The target selector was not found. Use "@extend .button !optional" to avoid this error. ╷ 139 │ @extend .button; │ ^^^^^^^^^^^^^^^ ╵ resources/scss/components/_formy.scss 139:9 load-css() resources/scss/main.scss 27:1 root stylesheet ``` ``` [vite:css] [sass] The target selector was not found. Use "@extend .gold-gradient-button !optional" to avoid this error. ╷ 17 │ @extend .gold-gradient-button; │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ╵ resources/scss/components/_flag.scss 17:13 load-css() resources/scss/main.scss 22:1 root stylesheet ```
… from the webpack.mix.js utilizing native nodejs instead of laravel mix
… vite static asset versioning and update references to the file rather than the built file for vite to account for
… from the filename to prepare for the tailwind4 upgrade tool
…de from tailwind3 to tailwind4
…ded for now till we can figure out working style, then we can convert over to pure css issue with BEM currently in components/hero.css tailwindlabs/tailwindcss#18522 (comment)
…lwind.config.js since screens are not used anymore in tailwind4 correct stylelint to allow nesting-selector-no-missing-scoping-root to still work within the @Utility {utility name}
… with &::after taking on an error due to `::after:is()`
```
This errors if applied
▲ [WARNING] Unexpected ")" [css-syntax-error]
<stdin>:2:70272:
2 │ ...er){.play-video-button:after:is(),.play-video-button:after:hover...
╵
@apply group-hover:opacity-100 hover:opacity-100
```
757f20a to
6b848cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tailwind v3 -> v4, Laravel Mix -> Vite
Upgrade from Tailwind v3 to Tailwind v4 which also switches from Laravel Mix to using Vite
Reason for Change
Why was this change made? Briefly explain the motivation or issue being addressed.
Demo / Context
Add any context that would help reviewers understand the update. Include before/after info where helpful.
Final Checklist
Testing Notes
Optional: Explain any special testing considerations for this PR.
Thanks for your contribution! 🎉