Skip to content

Conversation

@breakdancingcat
Copy link
Member

Reason for Change

The modular repository adds a margin at the bottom of each component to maintain consistent spacing. However, there is no margin at the bottom of the content area when not using components.

This change adds a margin to the bottom of the <div class="layout>" element to ensure there is always space between the content and the footer.

The caveat, there will be whitespace when you have a full width component that needs to butt up against the social footer. Future updates can address whether or not we will use logic to apply the margin or require a negative margin in the instance of a full width component that needs to butt up against the footer. Example: https://wayne.edu/about

Demo

Before After
image image

References

Final Checklist

  • I have reviewed my code and it follows project standards
  • I have tested the changes locally
  • [n/a] I have added or updated relevant documentation
  • [n/a] I have added tests (if applicable)
  • [n/a] I have communicated with the team about necessary post-deploy actions

@coveralls
Copy link

Coverage Status

coverage: 99.083%. remained the same
when pulling ca0b4b8 on feature/content-bottom-margin
into 31d82b2 on develop.

@breakdancingcat breakdancingcat self-assigned this Dec 18, 2025
@breakdancingcat breakdancingcat added this to the 8.16.0 Release milestone Dec 18, 2025
@breakdancingcat breakdancingcat linked an issue Dec 18, 2025 that may be closed by this pull request
Copy link
Member

@nickdenardis nickdenardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@KyleApsey KyleApsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@breakdancingcat breakdancingcat merged commit e96d37c into develop Dec 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG | Padding between content and footer is too tight

5 participants