Feature | Profiles | Refactor getGroupIds, parseProfileConfig, and orderProfilesById#853
Open
Feature | Profiles | Refactor getGroupIds, parseProfileConfig, and orderProfilesById#853
Conversation
Member
|
@Fw7424 Moved this back into draft mode to go over some things in the Basecamp task. |
…s to manage for default being passed in.
Member
|
@Fw7424 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change
I noticed a discrepancy between some custom field config variables were comma delimited and some were pipes. Originally groups_ids were setup as using pipes. This will allow for both while move towards a standard use of commas.
Demo
There are no visual changes
Post-Deploy Steps
This change is backwards compatible.
Final Checklist