Skip to content

Comments

Feature | Profiles | Refactor getGroupIds, parseProfileConfig, and orderProfilesById#853

Open
Fw7424 wants to merge 5 commits intodevelopfrom
feature/profiles-comma-delimited-group_id
Open

Feature | Profiles | Refactor getGroupIds, parseProfileConfig, and orderProfilesById#853
Fw7424 wants to merge 5 commits intodevelopfrom
feature/profiles-comma-delimited-group_id

Conversation

@Fw7424
Copy link
Contributor

@Fw7424 Fw7424 commented Jan 21, 2026

Reason for Change

I noticed a discrepancy between some custom field config variables were comma delimited and some were pipes. Originally groups_ids were setup as using pipes. This will allow for both while move towards a standard use of commas.

Demo

There are no visual changes

Post-Deploy Steps

This change is backwards compatible.

Final Checklist

  • I have reviewed my code and it follows project standards
  • I have tested the changes locally
  • I have added or updated relevant documentation
  • I have added tests (if applicable)
  • I have communicated with the team about necessary post-deploy actions

@Fw7424 Fw7424 requested a review from a team as a code owner January 21, 2026 21:55
@Fw7424 Fw7424 changed the base branch from master to develop January 21, 2026 21:55
@coveralls
Copy link

coveralls commented Jan 21, 2026

Coverage Status

coverage: 100.0% (+0.9%) from 99.083%
when pulling 7761afa on feature/profiles-comma-delimited-group_id
into cb9d554 on develop.

@breakdancingcat breakdancingcat marked this pull request as draft January 21, 2026 22:40
@breakdancingcat
Copy link
Member

breakdancingcat commented Jan 21, 2026

@Fw7424 Moved this back into draft mode to go over some things in the Basecamp task.

@Fw7424 Fw7424 changed the title Feature/profiles group_ids array delimiter Feature | Profiles | Refactor getGroupIds, parseProfileConfig, and orderProfilesById Jan 22, 2026
@Fw7424 Fw7424 marked this pull request as ready for review January 22, 2026 18:50
@breakdancingcat breakdancingcat self-requested a review February 2, 2026 15:50
@breakdancingcat breakdancingcat added this to the 8.16.0 Release milestone Feb 2, 2026
Copy link
Member

@breakdancingcat breakdancingcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nickdenardis
Copy link
Member

@Fw7424
Is this behind-the-scenes updates only, or does any of the styleguide documentation need to be updated?
https://base.wayne.edu/styleguide/profiles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants