Skip to content

Add CI#3

Merged
wayofthefuture merged 7 commits intomainfrom
add-ci
Apr 9, 2026
Merged

Add CI#3
wayofthefuture merged 7 commits intomainfrom
add-ci

Conversation

@HarelM
Copy link
Copy Markdown
Collaborator

@HarelM HarelM commented Apr 9, 2026

@HarelM HarelM requested a review from wayofthefuture April 9, 2026 07:47
@HarelM
Copy link
Copy Markdown
Collaborator Author

HarelM commented Apr 9, 2026

I've added some coverage to the code.
In order to get to 100% coverage there will be a need to write a minimal encoder so that one could actually understand what the tests are testing.
I'm guessing this encoder code exists somewhere as the messages here were generated by it...
So it would be better to port some of it here in order to make the tests more readable and maintainable.
I'll stop at this point as I think the ROI of getting to 100% might not be great.
Let me know what else is missing.

Comment thread src/ais-decoder.test.ts
decoder.parse('!AIVDM,2,1,seq1,channel1,hi,*51');
const result2 = decoder.parse('!AIVDM,2,2,seq1,channel2,hi,*51');
expect(result2.error).toBe('Part 2 message channel does not match part 1 channel.');
})
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@wayofthefuture wayofthefuture merged commit 2779041 into main Apr 9, 2026
1 check passed
@wayofthefuture wayofthefuture deleted the add-ci branch April 9, 2026 13:49
@HarelM
Copy link
Copy Markdown
Collaborator Author

HarelM commented Apr 9, 2026

I don't have repo permissions, but I think you need to enable something in codecov for the coverage to work as a badge and also as a PR comment.

@wayofthefuture
Copy link
Copy Markdown
Owner

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tasks

2 participants