Skip to content

add watch toggle setting#526

Merged
galister merged 6 commits into
wayvr-org:mainfrom
art0007i:main
Jun 3, 2026
Merged

add watch toggle setting#526
galister merged 6 commits into
wayvr-org:mainfrom
art0007i:main

Conversation

@art0007i

Copy link
Copy Markdown
Contributor

resolves #521

@galister

galister commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

This makes it so that you'd need to restart wayvr after toggling the checkbox.

It would make more sense to create the watch regardless of the setting. Simply hide by unsetting its active_state

@art0007i

art0007i commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

Well actually it deletes and recreates the watch dynamically when you toggle the checkbox but I can rework it to use the active state, since that seems like a cleaner approach anyway

Comment thread wayvr/src/backend/openxr/mod.rs
@galister

galister commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

neat, thanks.

i think there's a discrepancy in this that if the user places the watch on their right hand then toggles the watch off and back on, it will be back on the left hand. but this is not really easy to solve right now so it's fine to look at it later

it would likely involve using OverlayTask::ToggleOverlay instead of activate/deactivate. the former reads/writes states while the activate/deactivate is more for throwaway overlays like toasts etc.

@galister

galister commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

do another cargo fmt and it's good then

@galister galister merged commit 9806027 into wayvr-org:main Jun 3, 2026
5 checks passed
@galister

galister commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature request] disable watch

2 participants