fix: preserve screencopy transforms for rotated outputs#530
Merged
galister merged 1 commit intoJun 3, 2026
Merged
Conversation
Collaborator
|
neat, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm running sway 1.12 (wlroots), with a portrait screen configured with
rotate 90. On v26.2.1, the screen isn't properly detected as rotated. If I enableupright_screen_fix: true, the monitor gets positioned in portrait initially, but grabbing/moving it snaps it back to a horizontal screen; plus the curvature is along the long axis/edit mode UI is along it.This patch makes wlr-screencopy aware of the transform and instead modifies the UVs on the screen mesh so the screen displays in portrait. I'm not familiar enough with the rest of the codebase to say whether this the best way to do this, but it at least fixes the issue on my machine.