Skip to content

fix(live): hash issuerVkey before pool ID comparison#107

Merged
wcatz merged 1 commit intomasterfrom
fix/live-tail-pool-match
Mar 15, 2026
Merged

fix(live): hash issuerVkey before pool ID comparison#107
wcatz merged 1 commit intomasterfrom
fix/live-tail-pool-match

Conversation

@wcatz
Copy link
Copy Markdown
Owner

@wcatz wcatz commented Mar 15, 2026

Summary

  • Live tail compared raw 32-byte issuer VKey (64 hex) against 28-byte Blake2b-224 pool ID hash (56 hex) — could never match
  • Hashes VKey with Blake2b-224 via ledger.NewBlake2b224 before comparison
  • This is why no block notifications (Telegram/Twitter) have fired since the parallel live tail was added

Test plan

  • go build clean
  • All 69 tests pass
  • Koios confirms 16 blocks minted this epoch with zero notifications

The live tail compared the raw 32-byte issuer VKey against the 28-byte
Blake2b-224 pool ID hash — they can never match. Hash the VKey first
so our pool's blocks are correctly identified for notifications.
@wcatz wcatz merged commit 5e42e23 into master Mar 15, 2026
3 checks passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 15, 2026

Warning

Rate limit exceeded

@wcatz has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 8 minutes and 17 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ffba794a-9889-41e7-b115-cb264ca096be

📥 Commits

Reviewing files that changed from the base of the PR and between 134e0a6 and 4584b95.

📒 Files selected for processing (1)
  • main.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/live-tail-pool-match
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@wcatz wcatz deleted the fix/live-tail-pool-match branch March 15, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant