fix(nonce): remove wrong hardcoded epoch nonces#64
Merged
Conversation
The knownEpochNonces map contained incorrect values for epochs 210-211 that were poisoning the Koios verification comparison. Testing confirmed that self-computation from genesis produces correct nonces for ALL epochs including early Shelley — the D parameter transition does not affect nonce computation. Epochs 212-220 all verified against Koios with pure computation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughHardcoded early-Shelley epoch nonces (epochs 210-211) removed from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Feb 12, 2026
Closed
wcatz
added a commit
that referenced
this pull request
Feb 18, 2026
The knownEpochNonces map contained incorrect values for epochs 210-211 that were poisoning the Koios verification comparison. Testing confirmed that self-computation from genesis produces correct nonces for ALL epochs including early Shelley — the D parameter transition does not affect nonce computation. Epochs 212-220 all verified against Koios with pure computation. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
knownEpochNoncesRoot cause
The hardcoded values for epochs 210/211 were wrong. When BackfillNonces compared computed nonces against Koios, these wrong values caused mismatches that cascaded through the Koios fallback verification. The actual rolling nonce computation (etaV, etaC, labNonce, stability window) is correct and has been since the beginning.
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit