WIP: Log maven output to file #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobias-richter
requested changes
Feb 18, 2019
Contributor
tobias-richter
left a comment
tobias-richter
left a comment
There was a problem hiding this comment.
The idea itself is not questionable but maybe it is better to make this behavior optional.
I suggest to add a new variable like conga_maven_logfile which is not defined by default.
When the variable is defined we can add it to the _mvn_cmdline like in the task before (Add custom Maven settings).
So the users are able to switch this behavior on and off.
Contributor
|
I second @tobias-richter comment: I'd make it optional and provide the user the option to configure the log file name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.