Add one-time Stripe contribution link to payment settings and upgrade flow

[Copilot]

The payment settings page showed Stripe as the payment provider, but it did not expose the new one-time contribution flow for users who want to support the project directly. This updates /settings/payment to surface the Stripe-hosted contribution link inline in the existing copy, and adds the same Stripe contribution text to /subscription/upgrade above the existing “Contribute and support Sure” button.

• UI

  • Replaced the plain Payment via Stripe text with localized copy that renders:
    • Payment via Stripe (one-time contribution here)
  • Linked only the one-time contribution here phrase to the Stripe contribution URL
  • Used existing text-primary styling so the link remains readable in both light and dark themes
  • Opens the link in a new tab with noopener noreferrer
  • Falls back to plain Payment via Stripe text when no payment link can be resolved
  • Added the same Stripe payment copy to /subscription/upgrade directly above the “Contribute and support Sure” button

• Stripe integration

  • Removed the full contribution URL config approach
  • Uses STRIPE_PAYMENT_LINK_ID instead
  • Resolves the final Stripe payment-link URL through Provider::Stripe, similar to how Stripe pricing is already configured
  • Gracefully returns no link when the payment link ID is missing or Stripe lookup fails
  • Treats one-time payment links as optional by rescuing Stripe payment-link lookup failures, logging only at debug, and returning nil

• Localization

  • Moved the new payment copy into config/locales/views/settings/en.yml

• Refactor

  • Extracted shared Stripe contribution-copy rendering into a helper so /settings/payment and /subscription/upgrade stay in sync

• Coverage

  • Extended the existing payment settings controller test to assert the contribution link is rendered
  • Added coverage for the fallback behavior when the payment link ID is missing or unavailable
  • Added a Stripe provider test for payment-link URL lookup and error handling
  • Added subscription upgrade controller coverage for both linked and fallback contribution-copy states
  • Added helper coverage for the shared Stripe contribution-copy renderer

<%= stripe_one_time_contribution_text(@one_time_contribution_url) %>

• Screenshot
  • Settings UI reference: https://github.com/user-attachments/assets/50ac4b92-7cd5-4b77-a41c-ce1a6902e722
  • Upgrade UI reference: https://github.com/user-attachments/assets/905c9a8a-e82f-4eb0-9bf8-2fe8f03735e7

Summary by CodeRabbit

Release Notes

• New Features

  • Added one-time contribution payment link option to payment settings page
  • Added the same optional Stripe contribution copy to the subscription upgrade page above the contribution button
  • Payment link dynamically displays when properly configured
  • Gracefully handles unavailable links with fallback messaging

• Tests

  • Added comprehensive test coverage for payment link retrieval, configuration states, upgrade-page rendering, and shared helper output

[jjmata]

@copilot: Use STRIPE_PAYMENT_LINK_ID instead of STRIPE_ONE_TIME_CONTRIBUTION_URL and construct the URL using the Striple library similar to how STRIPE_MONTHLY_PRICE_ID is used.

[Copilot]

@copilot: Use STRIPE_PAYMENT_LINK_ID instead of STRIPE_ONE_TIME_CONTRIBUTION_URL and construct the URL using the Striple library similar to how STRIPE_MONTHLY_PRICE_ID is used.

Updated in 2a3e95e to use STRIPE_PAYMENT_LINK_ID and resolve the contribution URL through Provider::Stripe/the Stripe client instead of storing a full URL in config. It also now falls back cleanly when the ID is missing or Stripe lookup fails. Screenshot: https://github.com/user-attachments/assets/50ac4b92-7cd5-4b77-a41c-ce1a6902e722

[jjmata]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 18ad929d-af59-42f6-964b-587b4108d69b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

📝 Walkthrough

Walkthrough

This PR introduces Stripe payment link support to the payments settings page. The controller initializes a @one_time_contribution_url from a Stripe payment link ID stored in environment variables, the Stripe provider gains a method to fetch payment link URLs with error handling, and the view conditionally renders a contribution link when available, with supporting localization strings.

Changes

Cohort / File(s)	Summary
Stripe Provider Implementation app/models/provider/stripe.rb, test/models/provider/stripe_test.rb	Added payment_link_url(payment_link_id:) method to fetch Stripe payment links via the Stripe client; includes error handling with Sentry capture and logging on StandardError. Tests verify successful URL retrieval and failure scenarios.
Payment Settings Controller app/controllers/settings/payments_controller.rb, test/controllers/settings/payments_controller_test.rb	Modified show action to initialize @one_time_contribution_url from environment variable STRIPE_PAYMENT_LINK_ID via the Stripe provider. Tests verify link rendering when URL is present, fallback text when URL is nil, and behavior when payment link ID is missing.
Payment Settings View & Localization app/views/settings/payments/show.html.erb, config/locales/views/settings/en.yml	Updated view to conditionally render contribution link with target="_blank" and rel="noopener noreferrer" when URL is available, otherwise show fallback text. Added three new translation keys: payment_via_stripe, payment_via_stripe_html (with %{contribution_link} interpolation), and one_time_contribution_link_text.

Sequence Diagram

sequenceDiagram
    participant User as User/Browser
    participant Controller as PaymentsController
    participant Stripe as Provider::Stripe
    participant StripeAPI as Stripe API
    participant View as View/Template

    User->>Controller: GET /settings/payments
    Controller->>Controller: Read STRIPE_PAYMENT_LINK_ID from ENV
    alt Payment Link ID present
        Controller->>Stripe: stripe.payment_link_url(payment_link_id)
        Stripe->>StripeAPI: client.v1.payment_links.retrieve(id)
        StripeAPI-->>Stripe: return payment_link object
        Stripe-->>Controller: return url (or nil on error)
        Controller->>Controller: Assign `@one_time_contribution_url`
    else Payment Link ID missing
        Controller->>Controller: `@one_time_contribution_url` remains nil
    end
    Controller->>View: Render with `@one_time_contribution_url`
    alt URL present
        View->>View: Render link_to with contribution URL
    else URL nil/missing
        View->>View: Render fallback text
    end
    View-->>User: HTML response

Loading

Estimated Code Review Effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly Related PRs

• Rename billing to payment throughout the codebase #726: Touches the same controller, view, and Provider::Stripe class; directly related to payment functionality reshaping in Settings::PaymentsController.
• Hide contribution payments from demo user(s) #738: Modifies Settings::PaymentsController#show action; this PR's payment link initialization logic is adjacent to access guard functionality in that PR.

Poem

🐰 A hop through Stripe we now shall make,
With payment links for every's sake,
Contributions flow with graceful ease,
Our users smile, our code will please! 💳✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Add one-time Stripe contribution link to payment settings' accurately and concisely describes the main change in the pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch copilot/add-crypto-donation-option

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

app/views/settings/payments/show.html.erb (1)

63-75: Optional: move contribution-link composition to a helper for cleaner ERB.

The block is correct, but extracting the link/text composition would keep the template slimmer and easier to scan.

As per coding guidelines "app/**/*.erb: Avoid heavy logic in ERB view files; prefer helpers and components instead."

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@app/views/settings/payments/show.html.erb` around lines 63 - 75, Extract the
link-building logic from the view into a helper method (e.g.,
one_time_contribution_link(url) or contribution_link_for_one_time_contribution)
that accepts `@one_time_contribution_url` and returns the fully composed link
(class, target, rel, and translated text), then replace the inline block in the
view with a call that assigns contribution_link =
helper_method(`@one_time_contribution_url`) and passes it into
t(".payment_via_stripe_html", contribution_link: contribution_link); ensure the
helper returns an HTML-safe string suitable for the translation interpolation
and keep the helper name referenced where `@one_time_contribution_url` and
payment_via_stripe_html are used.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@app/views/settings/payments/show.html.erb`:
- Around line 63-75: Extract the link-building logic from the view into a helper
method (e.g., one_time_contribution_link(url) or
contribution_link_for_one_time_contribution) that accepts
`@one_time_contribution_url` and returns the fully composed link (class, target,
rel, and translated text), then replace the inline block in the view with a call
that assigns contribution_link = helper_method(`@one_time_contribution_url`) and
passes it into t(".payment_via_stripe_html", contribution_link:
contribution_link); ensure the helper returns an HTML-safe string suitable for
the translation interpolation and keep the helper name referenced where
`@one_time_contribution_url` and payment_via_stripe_html are used.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 203afdb2-5dc8-491f-80f4-7a473351ad37

📥 Commits

Reviewing files that changed from the base of the PR and between 281197f and 2a3e95e.

📒 Files selected for processing (6)

• app/controllers/settings/payments_controller.rb
• app/models/provider/stripe.rb
• app/views/settings/payments/show.html.erb
• config/locales/views/settings/en.yml
• test/controllers/settings/payments_controller_test.rb
• test/models/provider/stripe_test.rb

[jjmata]

@copilot: fix the CI test failures

[Copilot]

@copilot: fix the CI test failures

Fixed in 88b130e. The failing CI tests were caused by stubbing ENV[] in Settings::PaymentsControllerTest, which intercepted unrelated environment reads during the request. I narrowed the stubs to payment_link_id on the controller, which keeps the tests focused and avoids the Mocha unexpected invocation failures. Screenshot: https://github.com/user-attachments/assets/50ac4b92-7cd5-4b77-a41c-ce1a6902e722

[jjmata]

@copilot: Make sure you add the same text in /subscription/upgrade right above the "Contribute and support Sure" button.

[Copilot]

@copilot: Make sure you add the same text in /subscription/upgrade right above the "Contribute and support Sure" button.

Updated in f82e203. I added the same Stripe contribution copy above the button on /subscription/upgrade, wired the upgrade action to fetch the optional payment-link URL, and extracted the shared rendering into a helper so the upgrade and settings pages stay in sync. I also added focused controller/helper coverage for both linked and fallback states. Screenshot: https://github.com/user-attachments/assets/905c9a8a-e82f-4eb0-9bf8-2fe8f03735e7

[sure-design]

Periodic PR sweep status check: CI was green as of the last commit run (May 12), and the requested /subscription/upgrade contribution copy (f82e203) was added after @jjmata's April 6 approval, but that addition hasn't had an explicit re-review since. The branch currently shows merge conflicts with main (mergeable_state: dirty) and will need a rebase before it can be merged.

---

Generated by Claude Code

[sure-design]

Automated review sweep: this PR was formally approved months ago and has sat idle since (only a trivial merge/whitespace commit since approval). Flagging as ready to merge — no outstanding blockers.

---

Generated by Claude Code