fix: update prettier to respect stderr and stdout concurrently#722
Open
tractorcow wants to merge 4 commits intowearerequired:masterfrom
Open
fix: update prettier to respect stderr and stdout concurrently#722tractorcow wants to merge 4 commits intowearerequired:masterfrom
tractorcow wants to merge 4 commits intowearerequired:masterfrom
Conversation
Author
|
For context this is the kind of If I were to parse this instead of output.stdout |
Author
Author
|
Unit tests presented :) |
tractorcow
commented
Sep 21, 2023
| * @param {string} str - Console output to escape | ||
| * @returns {string} - Pure ansi output | ||
| */ | ||
| function removeANSIColorCodes(str) { |
Author
There was a problem hiding this comment.
I had trouble even with -no-colors with unit tests locally. Perhaps some limitation of the command line tool?
Contributor
|
Thank you for your contribution to this project! This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

In cases where prettier fails to run (see #718)
output.stdoutcan be empty. Generating an annotation with a blankpathcauses a 422 validation error pushing this check to github.I have updated the logic to check both stdout and stderr, applying appropriate checks and reporting where available.