Allow using non-row panels in dashboard's panels #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in grafana/grafana#50855 (comment), panels of rows with collapsed=False should be added to the list of panels that contains that row. Adding non-row panels makes auto_panel_ids() fail with ``` File ".../grafanalib/core.py", line 1751, in auto_panel_ids ids = set([panel.id for panel in self._iter_panels() if panel.id]) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File ".../grafanalib/core.py", line 1731, in _iter_panels for row_panel in panel._iter_panels(): ^^^^^^^^^^^^^^^^^^ AttributeError: 'TimeSeries' object has no attribute '_iter_panels' ``` This change fixes this exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
As discussed in grafana/grafana#50855 (comment), panels of rows with collapsed=False should be added to the list of panels that contains that row.
Adding non-row panels makes auto_panel_ids() fail with
This change fixes this exception.