Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple helm repos #3176

Closed
wants to merge 70 commits into from
Closed

Multiple helm repos #3176

wants to merge 70 commits into from

Conversation

AlinaGoaga
Copy link
Contributor

@AlinaGoaga AlinaGoaga commented Aug 7, 2023

Closes #1177

What changed?

  • Previously only one HelmRepository object, weaveworks-charts, could be defined pointing to a single helm chart repository for profile installation. Now users will be able to configure multiple helm repositories to be used and available for profile installation. If no helm repos are set up, we default to weaveworks-charts.
  • The required profiles section in template can also now specify a sourceRef.

How did you validate the change?
Updated existing tests to reflect changes.

Documentation Changes
Docs update PR

@AlinaGoaga AlinaGoaga added the enhancement New feature or request label Aug 7, 2023
AlinaGoaga and others added 26 commits August 7, 2023 17:27
…could be multiple repositories with same name in different namespaces
…amespace from changing position and change encodedProfiles data to send profile values for multiple repos
…te rendering to instead write out all the diff helmrepos - WIP
…te rendering to instead write out all the diff helmrepos - WIP2
@AlinaGoaga AlinaGoaga marked this pull request as ready for review October 17, 2023 10:48
@foot
Copy link
Collaborator

foot commented Oct 19, 2023

🔥 !

  • the filter box seems to get cleared if you type a filter in there like podinfo
  • clicking the select al checkbox when you have a filter still seems to select everything
  • we only seem to get a single podinfo helmrelease in the preview etc even if you select all 4 of them, I think on the BE would should perhaps start including the name of the source in the filename.. and the helmrelease.name too? 🤔

Love seeing the namespace in the profiles table source column, 🙌

@foot
Copy link
Collaborator

foot commented Oct 30, 2023

we only seem to get a single podinfo helmrelease in the preview etc even if you select all 4 of them, I think on the BE would should perhaps start including the name of the source in the filename.. and the helmrelease.name too? 🤔

Added a constraint for this in the BE, throws an error now

Some things I think we should address first:

  • Typing in field values is very slow now
  • We load all the helm charts from all the helm repos on page load, need to avoid that as it could be a lot.
  • HelmRepositories in other namespaces like monitoring or podinfo still have these namespaces when being copied to the new cluster, but these namespaces don't exist. I think we limit the helmrepos we show to just flux-system for now? Then can relax this constraint in the future too.

@foot
Copy link
Collaborator

foot commented Dec 19, 2023

On pausa for now.

@foot foot closed this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using more than one Helm repositories for profiles for installation
2 participants