Turn on protolinting for snake_case #4134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikgb
force-pushed
the
api-clean-up-snake-case
branch
from
2364c76 to
5f3bcaf
Compare
erikgb
approved these changes
Jan 18, 2025
- And fix up field names
erikgb
force-pushed
the
api-clean-up-snake-case
branch
from
5f3bcaf to
b878b15
Compare
casibbald
approved these changes
Jan 19, 2025
This was referenced Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaks out part of #4005 into a small chunk
What changed?
FIELD_NAMES_LOWER_SNAKE_CASElintingWhy was this change made?
Field names now conform to the snake case style guide we want to follow https://protobuf.dev/programming-guides/style/
How was this change implemented?
Using the
-fixflag in the command:protolint lint -fix -config_path=.protolint.yaml ./apiHow did you validate the change?
Release notes
Documentation Changes