This repository was archived by the owner on Jun 20, 2024. It is now read-only.
Deal with moving MACs - #2437
Open
rade wants to merge 6 commits into
Open
Conversation
Member
Author
|
Things left to do:
|
| router.Overlay.(NetworkOverlay).InvalidateRoutes() | ||
| } | ||
| } | ||
|
|
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Contributor
|
@brb did you mean for this to still be assigned to you? |
Contributor
|
Yep, as I haven't convinced myself that we do not introduce loops. |
Contributor
|
Needs rebasing on |
otherwise NetworkRouter.handleForwardedPacket fails to clear out the now invalid flows.
We see such packets when a MAC that we previously saw at a remote peer has been moved to ours. Dropping these packets cuts off network connectivity for the new owner of the MAC. Instead we update the MAC cache and flush the flows, to remove the now incorrect entries for that MAC. And carry on as normal.
The absence of the deletion might lead to installation of invalid flows, because the fastdp bridge MAC cache can have stale entries which are used when deciding when/what flows to create.
The former function is obsolete.
The function updates the MAC cache and invalidates routes if needed.
Contributor
|
Coming up on two years: what should we do with this? |
Contributor
|
I'd prefer to bring this PR to life. First I'd need to refresh context though. Perhaps, it could happen when working on #2877 |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2436