Skip to content

fix(browser): guard Browser.create against undefined launch options (#117) #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
linhongyu510 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(browser): guard Browser.create against undefined launch options (#117) #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/browser/example/browser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ import { Browser } from '../src/index.node';

async function main() {
const browser = await Browser.create({
headless: false,
launchOrConnect: {
headless: false,
},
});

const tab = browser.getActiveTab();
Expand Down
4 changes: 2 additions & 2 deletions packages/browser/src/browser/browser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export class Browser extends BaseBrowser<Tabs> {
options: { launchOrConnect: LaunchOptions } = { launchOrConnect: {} },
): Promise<Browser> {
const browser = new Browser();
await browser.#init(options.launchOrConnect);
await browser.#init(options.launchOrConnect ?? {});
return browser;
}

Expand Down Expand Up @@ -71,7 +71,7 @@ export class Browser extends BaseBrowser<Tabs> {

// #region launch & connect

async #init(options: LaunchOptions): Promise<void> {
async #init(options: LaunchOptions = {}): Promise<void> {
const processedOptions = this.#processOptions(options);

if (this.#isConnectMode(processedOptions)) {
Expand Down