fix: make puppeteer external in web-integration

web-infra-dev · Dec 25, 2024 · a7ab239 · a7ab239
1 parent 05dad23
commit a7ab239
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/web-integration/modern.config.ts b/packages/web-integration/modern.config.ts
@@ -20,6 +20,6 @@ export default defineConfig({
       yaml: 'src/yaml/index.ts',
     },
     target: 'es2018',
-    externals: ['@midscene/core', '@midscene/shared'],
+    externals: ['@midscene/core', '@midscene/shared', 'puppeteer'],
   },
 });
diff --git a/packages/web-integration/src/puppeteer/agent-launcher.ts b/packages/web-integration/src/puppeteer/agent-launcher.ts
@@ -1,6 +1,5 @@
 import assert from 'node:assert';
 import { readFileSync } from 'node:fs';
-import puppeteer from 'puppeteer';
 
 import { PuppeteerAgent } from '@/puppeteer';
 import type { MidsceneYamlScriptEnv } from '@midscene/core';
@@ -72,6 +71,7 @@ export async function puppeteerAgentForTarget(
       'you are probably running headed mode in CI, this will usually fail.',
     );
   }
+  const puppeteer = await import('puppeteer');
   const browser = await puppeteer.launch({
     headless: !headed,
     args: [