perf: cache resolved system Chrome path#2337
Open
vincerevu wants to merge 2 commits intoweb-infra-dev:mainfrom
Open
perf: cache resolved system Chrome path#2337vincerevu wants to merge 2 commits intoweb-infra-dev:mainfrom
vincerevu wants to merge 2 commits intoweb-infra-dev:mainfrom
Conversation
Previously, `getSystemChromePath` repeatedly called `existsSync` within an array of path lookups. This introduces a module-level variable to cache the first successful resolution, avoiding subsequent synchronous filesystem accesses. Also added an export `clearSystemChromePathCache` utility to preserve test isolation. This optimization speeds up repeated Chrome path resolutions from ~30ms down to ~1.4ms (for 10k iterations).
Previously, `getSystemChromePath` repeatedly called `existsSync` within an array of path lookups. This introduces a module-level variable to cache the first successful resolution, avoiding subsequent synchronous filesystem accesses. Also added an export `clearSystemChromePathCache` utility to preserve test isolation. This optimization speeds up repeated Chrome path resolutions from ~30ms down to ~1.4ms (for 10k iterations).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Introduced a cachedSystemChromePath variable to cache the resolved path returned by getSystemChromePath. Added a clearSystemChromePathCache function to reset the cache between test cases.
Why:
getSystemChromePath uses node:fs existsSync checks synchronously across an array of possible paths. Repeated calls hit the filesystem unnecessarily since the Chrome path normally doesn't change during a process runtime. Caching the result improves initialization speed and minimizes disk I/O operations.
Measured Improvement:
A benchmark looping 10,000 times showed:
Before (uncached): ~30.3ms
After (cached): ~1.4ms
This represents a >20x speedup in the target code path.