Skip to content

feat(report): support WebP screenshot consumers - #2857

Closed
quanruzhuoxiu wants to merge 1 commit into
feat/webp-core-screenshot-lifecyclefrom
feat/webp-report-consumers
Closed

feat(report): support WebP screenshot consumers#2857
quanruzhuoxiu wants to merge 1 commit into
feat/webp-core-screenshot-lifecyclefrom
feat/webp-report-consumers

Conversation

@quanruzhuoxiu

Copy link
Copy Markdown
Collaborator

Summary

  • resolve screenshot sources by their real MIME type in the report UI and timeline
  • export Markdown screenshots with format-aware file extensions
  • preserve WebP assets in report split, merge, CLI, and verbose screenshot flows
  • update visualizer consumers and the bilingual API documentation
  • add regression coverage across shared, core, report, and visualizer consumers

Stack

This is PR 4 of 4 for the WebP foundation split.

Validation

  • pnpm exec nx run-many -t build -p @midscene/shared @midscene/core @midscene/report @midscene/visualizer
  • pnpm --filter @midscene/shared test (33 files, 433 tests passed)
  • pnpm --filter @midscene/core test (124 files, 1,352 passed, 8 skipped)
  • pnpm --filter @midscene/report test (16 files, 87 tests passed)
  • pnpm --filter @midscene/visualizer test (21 files, 104 tests passed)
  • pnpm run type-check:tests
  • pnpm run lint

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 23, 2026

Copy link
Copy Markdown

Deploying midscene with  Cloudflare Pages  Cloudflare Pages

Latest commit: ebfa101
Status: ✅  Deploy successful!
Preview URL: https://7cb2662f.midscene.pages.dev
Branch Preview URL: https://feat-webp-report-consumers.midscene.pages.dev

View logs

@quanruzhuoxiu
quanruzhuoxiu force-pushed the feat/webp-core-screenshot-lifecycle branch from 1c2eced to 74937f8 Compare July 23, 2026 11:56
@quanruzhuoxiu
quanruzhuoxiu force-pushed the feat/webp-report-consumers branch from 675a785 to 92530ad Compare July 23, 2026 11:56
@quanruzhuoxiu
quanruzhuoxiu force-pushed the feat/webp-core-screenshot-lifecycle branch from 74937f8 to eb26577 Compare July 24, 2026 07:44
@quanruzhuoxiu
quanruzhuoxiu force-pushed the feat/webp-report-consumers branch from 92530ad to ebfa101 Compare July 24, 2026 07:45
@quanru
quanru marked this pull request as ready for review July 28, 2026 02:17

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ebfa101363

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

}
const extension = screenshotImageExtension(format);
return new URL(
`screenshots/${encodeURIComponent(ref.id)}.${extension}`,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Serve the WebP replay URLs generated here

In the server-backed playground flow, a WebP reference now resolves to screenshots/<id>.webp, but the corresponding route in packages/playground/src/server.ts:3098-3102 accepts only png|jpe?g assets and therefore returns HTTP 400. Consequently, replay dumps load but every lazily rendered WebP screenshot is broken in both playground consumers; extend that route and its response MIME mapping to support WebP.

Useful? React with 👍 / 👎.

@quanruzhuoxiu

Copy link
Copy Markdown
Collaborator Author

Closing this superseded WebP stack PR. The replacement stack is #3012#3013#3014 and incorporates the latest main branch plus the follow-up architecture, format-validation, and CI fixes. PR #2856 remains open because it is an independent model-input evidence change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant