fix(core): normalize GPT locate coordinates - #3057
Closed
quanru wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
GPT does not know the authoritative pixel dimensions of the image after provider-side image handling. Asking it for absolute pixels allowed a valid bottom-edge element to be returned beyond the local screenshot height. Normalizing the model contract removes that size guess and lets Midscene perform the only pixel conversion.
Fixes #2929
Validation
pnpm exec nx test @midscene/core -- tests/unit-test/model-adapter/gpt.test.ts(11 tests)pnpm exec nx test @midscene/core -- tests/unit-test/prompt/prompt.test.ts(34 tests)pnpm exec nx build @midscene/corepnpm run lintgit diff --checkNo live GPT request was run because the required model credentials were not available; the adapter prompt and coordinate conversion are covered directly.