Skip to content

test(app-tools): isolate ts-node-loader fixture config#8542

Merged
9aoy merged 1 commit intomainfrom
9aoy/fix-ts-node-loader-test-ci
Apr 13, 2026
Merged

test(app-tools): isolate ts-node-loader fixture config#8542
9aoy merged 1 commit intomainfrom
9aoy/fix-ts-node-loader-test-ci

Conversation

@9aoy
Copy link
Copy Markdown
Contributor

@9aoy 9aoy commented Apr 13, 2026

Summary

This PR fixes a eco-CI-only failure in ts-node-loader.test.ts where ts-node could pick up a workspace-level tsconfig with unsupported moduleResolution values in eco-ci. The test now uses an isolated temporary tsconfig and runs the child process from the fixture root so resolution stays deterministic across environments.

Related Links

fix: https://github.com/rstackjs/rstack-ecosystem-ci/actions/runs/24324272940/job/71016372656

test ci: https://github.com/rstackjs/rstack-ecosystem-ci/actions/runs/24329567135

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 13, 2026

Deploy Preview for modernjs-byted ready!

Name Link
🔨 Latest commit 5e4a473
🔍 Latest deploy log https://app.netlify.com/projects/modernjs-byted/deploys/69dc909d9bddb800080e348f
😎 Deploy Preview https://deploy-preview-8542--modernjs-byted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🔴 down 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 13, 2026

⚠️ No Changeset found

Latest commit: 5e4a473

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

Rsdoctor Bundle Diff Analysis

📊 Quick Summary
Project Total Size Change
bundle-diff 2.9 MB 0

Generated by Rsdoctor GitHub Action

@9aoy 9aoy marked this pull request as ready for review April 13, 2026 06:52
@9aoy 9aoy requested review from Timeless0911 and zllkjc April 13, 2026 06:52
@9aoy 9aoy merged commit dd0764c into main Apr 13, 2026
10 checks passed
@9aoy 9aoy deleted the 9aoy/fix-ts-node-loader-test-ci branch April 13, 2026 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants