fix: html report download file extension problem#37
Merged
Conversation
Rsdoctor Bundle Diff AnalysisFound 2 projects in monorepo, 2 projects with changes. 📊 Quick Summary
📋 Detailed Reports (Click to expand)📁 rsbuild-demoPath:
📁 rsbuild-demo2Path:
Generated by Rsdoctor GitHub Action |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts how GitHub Action artifacts are named (removing the source file extension from the artifact name) to improve artifact lookup/download behavior, and updates the compiled dist bundle accordingly.
Changes:
- Remove file-extension suffix from uploaded artifact names in
uploadArtifact. - Update
downloadArtifactByCommitHashto search for artifacts using the new (extension-less) naming scheme. - Minor cleanup in an example React app and rebuild of
dist/index.js.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/upload.ts | Stops appending the file extension to the artifact name during upload. |
| src/download.ts | Updates expected artifact name format to match the new upload naming scheme. |
| examples/rsbuild-demo2/src/App.tsx | Removes a duplicated/extra “info-section” block from the demo UI. |
| dist/index.js | Rebuilt output reflecting the updated artifact naming logic. |
yifancong
changed the title
yifancong
force-pushed
the
fix/html-report-download
branch
from
0ac4d2b to
388e440
Compare
This was referenced Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.