Conversation
✅ Deploy Preview for rsdoctor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds pnpm trustPolicy configuration to prevent package downgrades and updates UI text in a component. The trustPolicy is set to no-downgrade with an exclusion for ua-parser-js.
Key Changes
- Added trustPolicy configuration with
no-downgradesetting and exclusion for ua-parser-js - Simplified the ModuleResolve page title from "Webpack Resolver Analysis" to "Resolver Analysis"
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pnpm-workspace.yaml | Adds trustPolicy configuration to prevent package version downgrades |
| packages/components/src/pages/ModuleResolve/index.tsx | Simplifies page title and reformats component props |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| trustPolicy: no-downgrade | ||
| trustPolicyExclude: | ||
| - ua-parser-js@1.0.41 |
There was a problem hiding this comment.
Version mismatch: The trustPolicyExclude specifies ua-parser-js@1.0.41, but the pnpm-lock.yaml shows the project is using ua-parser-js@1.0.40. The version in the exclusion list should match the actual version being used in the project. Please update this to ua-parser-js@1.0.40.
| - ua-parser-js@1.0.41 | |
| - ua-parser-js@1.0.40 |
|
|
||
| trustPolicy: no-downgrade | ||
| trustPolicyExclude: | ||
| - ua-parser-js@1.0.41 |
There was a problem hiding this comment.
The trustPolicy and trustPolicyExclude settings should be configured in .npmrc file, not in pnpm-workspace.yaml. The pnpm-workspace.yaml file is specifically for defining workspace packages, while pnpm configuration options like trustPolicy belong in .npmrc.
These lines should be moved to .npmrc in the following format:
trust-policy=no-downgrade
trust-policy-exclude[]=ua-parser-js@1.0.41
| trustPolicy: no-downgrade | |
| trustPolicyExclude: | |
| - ua-parser-js@1.0.41 |
Summary
Related Links