chore: modernize Rsbuild minimal example - #1950
Merged
Merged
Conversation
@rsdoctor/agent-cli
@rsdoctor/cli
@rsdoctor/client
@rsdoctor/core
@rsdoctor/shared
commit: |
chenjiahan
changed the title
Deploying rsdoctor-v1 with
|
| Latest commit: |
b400fd4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b181b4d0.rsdoctor-v1.pages.dev |
| Branch Preview URL: | https://chenjiahan-refactor-rsbuild.rsdoctor-v1.pages.dev |
Contributor
There was a problem hiding this comment.
Pull request overview
Modernizes the examples/rsbuild-minimal project to align with current Rsbuild configuration patterns by simplifying source configuration, switching Rsdoctor registration to Rspack plugin injection via tools.rspack, and updating the example package metadata/scripts to ESM + current CLI usage.
Changes:
- Update
rsbuild.config.tsto registerRsdoctorRspackPluginviatools.rspack.pluginsand remove the explicitsource.include. - Mark the example package as ESM (
"type": "module") and simplify package metadata. - Update example scripts to use the modern Rsbuild CLI invocation style.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| examples/rsbuild-minimal/rsbuild.config.ts | Switches Rsdoctor integration to tools.rspack.plugins and streamlines source settings. |
| examples/rsbuild-minimal/package.json | Marks the example as ESM and updates scripts/metadata to match the modernized setup. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR modernizes the minimal Rsbuild example to match the current Rsbuild CLI and Rspack configuration APIs.
It marks the package as ESM, removes redundant metadata and source inclusion, and registers Rsdoctor through
tools.rspack.plugins.Related Links
None