Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support rspack native plugin #710

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LingyuCoder
Copy link
Collaborator

@LingyuCoder LingyuCoder commented Jan 17, 2025

Summary

Relate to web-infra-dev/rspack#8930

With native rspack plugin

done graph end parse bundle open browser
1 6.246 6.246 6.788 8.428
2 6.198 6.198 6.727 8.222
3 6.309 6.309 6.883 8.458
4 6.111 6.111 6.629 8.109
5 6.025 6.025 6.549 7.99

Without native rspack plugin

done graph end parse bundle open browser
1 6.246 7.485 7.987 9.447
2 6.072 7.291 7.81 9.256
3 6.092 7.328 7.886 9.345
4 6.152 7.356 7.877 9.329
5 6.287 7.528 8.072 9.54

Related Links

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for rsdoctor ready!

Name Link
🔨 Latest commit 0acd4bc
🔍 Latest deploy log https://app.netlify.com/sites/rsdoctor/deploys/678a64d6bb988a0008ef2207
😎 Deploy Preview https://deploy-preview-710--rsdoctor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LingyuCoder LingyuCoder force-pushed the feat/rspack-native-plugin branch from f57bdb3 to a556f69 Compare January 17, 2025 14:08
@LingyuCoder LingyuCoder force-pushed the feat/rspack-native-plugin branch from a556f69 to 0acd4bc Compare January 17, 2025 14:10
@@ -50,7 +50,8 @@
},
"pnpm": {
"overrides": {
"react-dom": "18.3.1"
"react-dom": "18.3.1",
"@rspack/core": "npm:@rspack-canary/[email protected]"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be removed after publishing @rspack/[email protected]

@@ -21,7 +21,7 @@
"test": "cross-env NODE_OPTIONS=--max-old-space-size=8192 pnpm run ut",
"test:all": "pnpm run test && pnpm run e2e",
"sort-package-json": "npx sort-package-json \"packages/*/package.json\"",
"ut": "vitest run",
"ut": "vitest run --poolOptions.threads.singleThread",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the latest canary version of rspack may lead to Segmentation fault (core dumped), use single thread before this is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant