feat: port rule no-useless-catch

[fansenze]

Summary

Port the no-useless-catch rule from ESLint to rslint.

Disallow unnecessary catch clauses

Related Links

• Tracking issue: [Tracking]: eslint core rules #223

• ESLint rule: https://eslint.org/docs/latest/rules/no-useless-catch

Checklist

• Tests updated (or not required).
• Documentation updated (or not required).

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the no-useless-catch linting rule to rslint, directly ported from ESLint. This new rule aims to improve code quality and readability by identifying and disallowing catch clauses that merely rethrow the caught exception. By flagging these redundant constructs, the rule encourages developers to either handle the error meaningfully or remove the unnecessary catch block, thereby simplifying control flow and reducing potential confusion.

Highlights

• New Linting Rule: Implemented the no-useless-catch rule, ported from ESLint, to identify and flag redundant catch clauses.
• Redundant Catch Detection: The rule detects catch blocks that simply rethrow the caught error without any intermediate processing.
• Contextual Reporting: Distinguishes between try-catch and try-catch-finally structures for reporting, providing specific messages for each scenario.
• Comprehensive Coverage: Included comprehensive documentation and tests, covering both valid and invalid code patterns, ensuring the rule's accuracy and reliability.

Changelog

• internal/config/config.go
  • Imported the no_useless_catch rule.
  • Registered the new rule within the global rule registry.
• internal/rules/no_useless_catch/no_useless_catch.go
  • Added the core implementation for the no-useless-catch rule.
  • Included AST traversal and logic to detect useless catch clauses.
• internal/rules/no_useless_catch/no_useless_catch.md
  • Created the documentation file for the no-useless-catch rule.
  • Detailed the rule's purpose, incorrect, and correct code examples.
• internal/rules/no_useless_catch/no_useless_catch_test.go
  • Implemented Go-based unit tests for the no-useless-catch rule.
  • Included valid and invalid test cases.
• packages/rslint-test-tools/rstest.config.mts
  • Updated the test configuration to include the new no-useless-catch rule's test files.
• packages/rslint-test-tools/tests/eslint/rules/snapshots/no-useless-catch.test.ts.snap
  • Generated snapshot tests for the no-useless-catch rule's diagnostics.
• packages/rslint-test-tools/tests/eslint/rules/no-useless-catch.test.ts
  • Added JavaScript-based test cases for the no-useless-catch rule using RuleTester.

Activity

• The author indicated that tests were updated.
• The author indicated that documentation was updated.
• No other review comments or activities have been recorded yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request successfully ports the no-useless-catch rule from ESLint to rslint. The implementation in no_useless_catch.go appears correct and follows the logic of the original rule. The documentation and test cases are also well-structured and comprehensive.