Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: compare performance with async fs version #38

Open
wants to merge 42 commits into
base: main
Choose a base branch
from
Open

Draft: compare performance with async fs version #38

wants to merge 42 commits into from
+1,377 −1,109

Conversation

nilptr
Copy link

@nilptr nilptr commented Dec 19, 2024

No description provided.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 19, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #38 will degrade performances by 80.4%

Comparing nilptr:nilptr/feat/async (7af89c3) with main (6cb5b89)

Summary

❌ 2 regressions
⁉️ 1 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⁉️ resolver[multi-thread] 91.8 ms N/A N/A
❌ resolver[resolve from symlinks] 71.7 ms 365.9 ms -80.4%
❌ resolver[single-thread] 86.8 ms 112.5 ms -22.85%

@stormslowly stormslowly force-pushed the nilptr/feat/async branch 2 times, most recently from cfccf22 to 7af89c3 Compare March 31, 2025 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilptr @stormslowly