Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support resolving path with extra query #54

Merged
merged 1 commit into from
Mar 27, 2025
Merged

feat: support resolving path with extra query #54

merged 1 commit into from
Mar 27, 2025

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Mar 15, 2025

@SoonIter SoonIter requested a review from stormslowly March 16, 2025 09:07
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 16, 2025

CodSpeed Performance Report

Merging #54 will not alter performance

Comparing unrs:feat/extra_query (622f99c) with main (82ef068)

Summary

✅ 3 untouched benchmarks

@stormslowly
Copy link
Contributor

stormslowly commented Mar 27, 2025 •
edited
Loading

Great job!!

it pass the edge case "./with-question-mark": "./with-?-file.js".
i will add that later!

@stormslowly stormslowly merged commit 6cb5b89 into web-infra-dev:main Mar 27, 2025
18 checks passed
@JounQin JounQin deleted the feat/extra_query branch March 27, 2025 11:14
@JounQin
Copy link
Contributor Author

JounQin commented Mar 27, 2025

Great job!!

it pass the edge case "./with-question-mark": "./with-?-file.js".

i will add that later!

Doesn't that been covered before this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stormslowly stormslowly stormslowly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JounQin @stormslowly