Skip to content

feat: watchOptions.followSymlinks follow resovel.symlinks by default #11835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: watchOptions.followSymlinks follow resovel.symlinks by default #11835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion packages/rspack/src/config/defaults.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ import type {
ResolveOptions,
RspackFutureOptions,
RuleSetRules,
SnapshotOptions
SnapshotOptions,
WatchOptions
} from "./types";

export const applyRspackOptionsDefaults = (
Expand Down Expand Up @@ -184,6 +185,9 @@ export const applyRspackOptionsDefaults = (
getResolveLoaderDefaults(),
options.resolveLoader
);

D(options, "watchOptions", {});
applyWatchOptionsDefaults(options.watchOptions, options.resolve);
};

export const applyRspackOptionsBaseDefaults = (
Expand Down Expand Up @@ -1065,6 +1069,14 @@ const applyOptimizationDefaults = (
}
};

const applyWatchOptionsDefaults = (
watchOptions: WatchOptions,
resolve: ResolveOptions
) => {
const followSymlinks = resolve.symlinks ?? true;
watchOptions.followSymlinks = watchOptions.followSymlinks ?? followSymlinks;
};

const getResolveLoaderDefaults = () => {
const resolveOptions: ResolveOptions = {
conditionNames: ["loader", "require", "node"],
Expand Down
4 changes: 3 additions & 1 deletion tests/rspack-test/defaultsCases/default/base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,9 @@ module.exports = {
stats: Object {},
target: web,
watch: false,
watchOptions: Object {},
watchOptions: Object {
followSymlinks: true,
},
}
`)
};
Loading