Skip to content

Conversation

chenjiahan
Copy link
Member

Summary

Fix invalid lint:rs script in the root package.json, the ./scripts/check_rust_dependency.cjs file does not exist.

image

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@Copilot Copilot AI review requested due to automatic review settings October 13, 2025 14:35
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fixes an invalid npm script by replacing a reference to a non-existent file with a proper Rust linting command.

  • Replaces broken lint:rs script that referenced non-existent ./scripts/check_rust_dependency.cjs
  • Updates script to use cargo clippy --workspace --all-targets for proper Rust linting

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

netlify bot commented Oct 13, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 2ce466e
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/68ed0e4730eb80000879a7be

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Oct 13, 2025
Copy link
Contributor

📦 Binary Size-limit

Comparing 2ce466e to chore(deps): update patch npm dependencies (#11806) by renovate[bot]

🎉 Size decreased by 283.25KB from 47.89MB to 47.62MB (⬇️0.58%)

Copy link

codspeed-hq bot commented Oct 13, 2025

CodSpeed Performance Report

Merging #11863 will not alter performance

Comparing fix_lint_rs_1013 (2ce466e) with main (a915dab)

Summary

✅ 17 untouched

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant