Skip to content

fix: exclude for const/let in/of decl from hoisted decls#14287

Merged
chenjiahan merged 5 commits into
mainfrom
fix/14274
Jun 24, 2026
Merged

fix: exclude for const/let in/of decl from hoisted decls#14287
chenjiahan merged 5 commits into
mainfrom
fix/14274

Conversation

@swwind

@swwind swwind commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Summary

fixes #14274

There is missing matches!(var_decl.kind, VarDeclKind::Var) when checking if var decl inside for in/of loop.

Old: for (const x in array) {} => var x

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

📦 Binary Size-limit

Comparing 8e55b4a to fix: handle cjs export assignment side effects (#14260) by Fy

🙈 Size remains the same at 67.74MB

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 0 projects with changes.

📊 Quick Summary
Project Total Size Gzip Size Change Gzip Change
popular-libs 1.7 MB 551.3 KB 0 0
react-10k 5.6 MB 1.3 MB 0 0
react-1k 822.8 KB 218.3 KB 0 0
ui-components 4.8 MB 1.4 MB 0 0
react-5k 2.7 MB 669.1 KB 0 0

Generated by Rsdoctor GitHub Action

@codspeed-hq

codspeed-hq Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 41 untouched benchmarks
⏩ 47 skipped benchmarks1


Comparing fix/14274 (8e55b4a) with main (7d8e6e4)

Open in CodSpeed

Footnotes

  1. 47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@chenjiahan chenjiahan requested a review from LingyuCoder June 8, 2026 03:20
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 10, 2026

Copy link
Copy Markdown

Deploying rspack with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8e55b4a
Status: ✅  Deploy successful!
Preview URL: https://d4e46cf9.rspack-v2.pages.dev
Branch Preview URL: https://fix-14274.rspack-v2.pages.dev

View logs

@chenjiahan chenjiahan requested a review from CPunisher June 12, 2026 02:26
@chenjiahan chenjiahan merged commit 930e7d8 into main Jun 24, 2026
55 of 57 checks passed
@chenjiahan chenjiahan deleted the fix/14274 branch June 24, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: dead code elimination produces variable name conflicts

3 participants