Skip to content

chore(release): bump all published crates in crate-version - #15367

Open
stormslowly wants to merge 2 commits into
mainfrom
chore/crate-version-force-all
Open

chore(release): bump all published crates in crate-version#15367
stormslowly wants to merge 2 commits into
mainfrom
chore/crate-version-force-all

Conversation

@stormslowly

Copy link
Copy Markdown
Contributor

Why

./x version <bump> fails on cargo codegen:

error: failed to select a version for the requirement `css-module-lexer = "=0.102.1"`
candidate versions found which didn't match: 0.102.2
required by package `rspack_plugin_css v0.102.2`

Every workspace member declares version.workspace = true, so bumping [workspace.package].version moves all crate versions at once. But cargo workspaces version only rewrites the =X.Y.Z pins in [workspace.dependencies] for the crates it includes in the version set, and --force 'rspack*' excludes css-module-lexer (name does not match the glob, and it had no changes since the last tag).

The result is a root Cargo.toml that cannot resolve: the pin still demands =0.102.1 while the crate itself is already 0.102.2. Note cargo workspaces version exits 0 and commits Release <version> anyway, so the repo is left half-released when the next cargo call dies.

This is not new — the 2.2.1 release hit the same thing (Release 0.102.1 left css-module-lexer = "=0.102.0") and it was patched by hand in the follow-up commit.

Before / after

--force result
omitted 75 crates bumped, rspack_binding_build = "=0.102.1" becomes the stale pin
'rspack*' 86 crates bumped, css-module-lexer = "=0.102.1" stale
'*' all published crates bumped, ./x version patch exits 0

Since versions move together, the "only bump what changed" selection has no meaning in this workspace — it just decides which pins get left behind. '*' turns it off.

Private crates (xtask, rspack_benchmark) are still skipped: cargo workspaces version needs -a/--all to touch them, which we do not pass.

@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

📦 Binary Size-limit

Comparing 5790ecf to chore(release):2.2.1 (#15359) by pshu

🙈 Size remains the same at 68.25MB

@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 5 projects with changes.

📊 Quick Summary
Project Total Size Gzip Size Change Gzip Change
popular-libs 1.7 MB 556.5 KB - -
react-10k 5.6 MB 1.3 MB - -
react-1k 823.1 KB 218.4 KB - -
react-5k 2.7 MB 669.3 KB - -
ui-components 4.9 MB 1.4 MB - -
📋 Detailed Reports (Click to expand)

📁 popular-libs

Path: ../build-tools-performance/cases/popular-libs/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 1.7 MB - -
🗜️ Gzip Size 556.5 KB - -
📄 JavaScript 1.7 MB - -
🎨 CSS 0 B - -
🌐 HTML 289.0 B - -
📁 Other Assets 0 B - -

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 5.6 MB - -
🗜️ Gzip Size 1.3 MB - -
📄 JavaScript 5.6 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 328.0 B - -
📁 Other Assets 0 B - -

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 823.1 KB - -
🗜️ Gzip Size 218.4 KB - -
📄 JavaScript 822.7 KB - -
🎨 CSS 0 B - -
🌐 HTML 328.0 B - -
📁 Other Assets 0 B - -

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.7 MB - -
🗜️ Gzip Size 669.3 KB - -
📄 JavaScript 2.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 328.0 B - -
📁 Other Assets 0 B - -

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 4.9 MB - -
🗜️ Gzip Size 1.4 MB - -
📄 JavaScript 4.8 MB - -
🎨 CSS 112.5 KB - -
🌐 HTML 328.0 B - -
📁 Other Assets 0 B - -

Generated by Rsdoctor GitHub Action

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the ./x crate-version release helper to ensure cargo-workspaces version includes all relevant crates in its version set, preventing stale =X.Y.Z pins in [workspace.dependencies] after bumping [workspace.package].version.

Changes:

  • Switches cargo workspaces version --force from rspack* to * to avoid leaving behind stale exact-version pins.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread scripts/x.mjs Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@codspeed-hq

codspeed-hq Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will degrade performance by 2.18%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 49 untouched benchmarks
⏩ 47 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation rust@mangle_exports 3.1 ms 3.2 ms -2.18%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing chore/crate-version-force-all (5790ecf) with main (e8ecb52)2

Open in CodSpeed

Footnotes

  1. 47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (1e06873) during the generation of this report, so e8ecb52 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@stormslowly stormslowly changed the title chore: bump all published crates in crate-version chore(release): bump all published crates in crate-version Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants