perf(ids): optimize deterministic module id assignment - #15393
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
📦 Binary Size-limit
🎉 Size decreased by 4.00KB from 68.30MB to 68.30MB (⬇️0.01%) |
Merging this PR will improve performance by 49.28%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | rust@create_module_ids |
4.9 ms | 3.3 ms | +49.28% |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing seal/profile-create-hash-react10k (0dd4dcf) with main (a68bb1e)
Footnotes
-
47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Rsdoctor Bundle Diff Analysis
Found 5 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
Summary
ModuleIdonly onceOn the React 10k production fixture with a warm persistent cache:
DeterministicModuleIdsPlugin: 11.905 ms -> 6.490 ms median (45.5% reduction)module idspass: 12.340 ms -> 7.646 ms median (38.0% reduction)Related links
N/A
Testing
cargo test -p rspack_util number_hashcargo check -p rspack_util -p rspack_idspnpm run build:binding:devpnpm run test:unit(9158 passed, 4 skipped; CLI 90 passed, 1 skipped)Checklist