perf(core): optimize create module hashes - #15396
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
📦 Binary Size-limit
❌ Size increased by 4.00KB from 68.30MB to 68.30MB (⬆️0.01%) |
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
Merging this PR will improve performance by 14.91%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | rust@create_module_hashes |
8.4 ms | 7.3 ms | +14.91% |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing seal/optimize-create-module-hashes (90f2db7) with main (f281cc9)
Footnotes
-
47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Summary
RuntimeSpecwhen filtering a singleton runtimeRspackHashDigestvalues instead of converting them to owned stringsCallgrind measurement on the React 10k production fixture without minification reduced the create module hashes stage from 705,923,691 IR to 557,307,083 IR, a 21.05% reduction. The baseline and optimized builds produced byte-identical output across all 19 emitted files.
Related links
N/A
Verification
cargo fmt --all -- --checkpnpm run build:binding:devpnpm run test:unitChecklist