Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move compilation ownership to javascript object #9679

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented Mar 14, 2025

Summary

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: feature release: feature related release(mr only) labels Mar 14, 2025
Copy link

netlify bot commented Mar 14, 2025

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit d4dc9f8
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67d96bd11b566000088d0801
😎 Deploy Preview https://deploy-preview-9679--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SyMind SyMind force-pushed the refactor-js-api-heap branch 2 times, most recently from a6267b8 to 5d0eadb Compare March 14, 2025 09:02
Copy link

codspeed-hq bot commented Mar 14, 2025

CodSpeed Performance Report

Merging #9679 will improve performances by 6.5%

Comparing refactor-js-api-heap (d4dc9f8) with main (9e9f198)

🎉 Hooray! codspeed-node just leveled up to 4.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

⚡ 1 improvements
✅ 7 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
Traverse module graph by connections 304.8 µs 286.1 µs +6.5%

@SyMind SyMind force-pushed the refactor-js-api-heap branch from 5d0eadb to 63c669e Compare March 14, 2025 09:25
Copy link
Contributor

github-actions bot commented Mar 14, 2025

📝 Benchmark detail: Open

Name Base (2025-03-14 09ac9ef) Current Change
10000_big_production-mode_disable-minimize + exec 36.5 s ± 983 ms 37 s ± 385 ms +1.43 %
10000_development-mode + exec 1.83 s ± 38 ms 1.74 s ± 23 ms -5.03 %
10000_development-mode_hmr + exec 700 ms ± 10 ms 692 ms ± 7.6 ms -1.22 %
10000_production-mode + exec 2.22 s ± 76 ms 2.15 s ± 60 ms -3.53 %
10000_production-mode_persistent-cold + exec 2.37 s ± 146 ms 2.29 s ± 65 ms -3.49 %
10000_production-mode_persistent-hot + exec 1.63 s ± 72 ms 1.61 s ± 171 ms -1.16 %
arco-pro_development-mode + exec 1.7 s ± 114 ms 1.73 s ± 108 ms +1.41 %
arco-pro_development-mode_hmr + exec 377 ms ± 3.2 ms 379 ms ± 2.3 ms +0.71 %
arco-pro_production-mode + exec 3.61 s ± 90 ms 3.49 s ± 48 ms -3.36 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.61 s ± 155 ms 3.52 s ± 159 ms -2.47 %
arco-pro_production-mode_persistent-cold + exec 3.67 s ± 112 ms 3.52 s ± 111 ms -4.20 %
arco-pro_production-mode_persistent-hot + exec 2.18 s ± 34 ms 2.35 s ± 170 ms +7.75 %
arco-pro_production-mode_traverse-chunk-modules + exec 3.52 s ± 78 ms 3.56 s ± 114 ms +1.17 %
large-dyn-imports_development-mode + exec 2.03 s ± 22 ms 1.98 s ± 33 ms -2.47 %
large-dyn-imports_production-mode + exec 2.04 s ± 30 ms 2.02 s ± 47 ms -1.24 %
threejs_development-mode_10x + exec 1.51 s ± 109 ms 1.49 s ± 19 ms -1.55 %
threejs_development-mode_10x_hmr + exec 834 ms ± 13 ms 825 ms ± 21 ms -1.03 %
threejs_production-mode_10x + exec 5.03 s ± 151 ms 4.99 s ± 39 ms -0.90 %
threejs_production-mode_10x_persistent-cold + exec 5.12 s ± 263 ms 5.12 s ± 356 ms -0.02 %
threejs_production-mode_10x_persistent-hot + exec 4.37 s ± 68 ms 4.35 s ± 201 ms -0.36 %
10000_big_production-mode_disable-minimize + rss memory 9583 MiB ± 241 MiB 9441 MiB ± 86.7 MiB -1.48 %
10000_development-mode + rss memory 673 MiB ± 14.5 MiB 707 MiB ± 34 MiB +5.10 %
10000_development-mode_hmr + rss memory 1458 MiB ± 129 MiB 1569 MiB ± 192 MiB +7.63 %
10000_production-mode + rss memory 638 MiB ± 34.8 MiB 684 MiB ± 49 MiB +7.17 %
10000_production-mode_persistent-cold + rss memory 758 MiB ± 74.8 MiB 816 MiB ± 50.4 MiB +7.65 %
10000_production-mode_persistent-hot + rss memory 716 MiB ± 37.2 MiB 753 MiB ± 42.1 MiB +5.11 %
arco-pro_development-mode + rss memory 576 MiB ± 86 MiB 590 MiB ± 71.3 MiB +2.42 %
arco-pro_development-mode_hmr + rss memory 584 MiB ± 60 MiB 661 MiB ± 64.9 MiB +13.16 %
arco-pro_production-mode + rss memory 737 MiB ± 51.8 MiB 753 MiB ± 70.6 MiB +2.22 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 734 MiB ± 36.3 MiB 739 MiB ± 70.7 MiB +0.75 %
arco-pro_production-mode_persistent-cold + rss memory 807 MiB ± 77.7 MiB 794 MiB ± 84 MiB -1.65 %
arco-pro_production-mode_persistent-hot + rss memory 649 MiB ± 18.1 MiB 779 MiB ± 112 MiB +19.98 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 729 MiB ± 46.3 MiB 709 MiB ± 53.1 MiB -2.85 %
large-dyn-imports_development-mode + rss memory 693 MiB ± 19.4 MiB 696 MiB ± 17.8 MiB +0.40 %
large-dyn-imports_production-mode + rss memory 558 MiB ± 4.89 MiB 569 MiB ± 27.1 MiB +2.01 %
threejs_development-mode_10x + rss memory 613 MiB ± 18.4 MiB 646 MiB ± 38.3 MiB +5.35 %
threejs_development-mode_10x_hmr + rss memory 756 MiB ± 31.1 MiB 935 MiB ± 77.1 MiB +23.72 %
threejs_production-mode_10x + rss memory 911 MiB ± 105 MiB 981 MiB ± 44.2 MiB +7.70 %
threejs_production-mode_10x_persistent-cold + rss memory 1002 MiB ± 60.7 MiB 1054 MiB ± 18.8 MiB +5.16 %
threejs_production-mode_10x_persistent-hot + rss memory 877 MiB ± 52.1 MiB 871 MiB ± 49.5 MiB -0.66 %

Threshold exceeded: ["arco-pro_production-mode_persistent-hot + exec"]

Copy link
Contributor

github-actions bot commented Mar 17, 2025

📝 Benchmark detail: Open

Name Base (2025-03-17 6dbba54) Current Change
10000_big_production-mode_disable-minimize + exec 36.3 s ± 675 ms 36.8 s ± 786 ms +1.32 %
10000_development-mode + exec 1.8 s ± 45 ms 1.75 s ± 78 ms -2.72 %
10000_development-mode_hmr + exec 719 ms ± 10 ms 699 ms ± 17 ms -2.78 %
10000_production-mode + exec 2.22 s ± 82 ms 2.16 s ± 52 ms -2.55 %
10000_production-mode_persistent-cold + exec 2.4 s ± 94 ms 2.32 s ± 93 ms -3.60 %
10000_production-mode_persistent-hot + exec 1.64 s ± 44 ms 1.62 s ± 89 ms -0.95 %
arco-pro_development-mode + exec 1.74 s ± 142 ms 1.76 s ± 119 ms +0.75 %
arco-pro_development-mode_hmr + exec 376 ms ± 2.1 ms 380 ms ± 5 ms +0.97 %
arco-pro_production-mode + exec 3.54 s ± 126 ms 3.52 s ± 108 ms -0.47 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.6 s ± 192 ms 3.61 s ± 242 ms +0.42 %
arco-pro_production-mode_persistent-cold + exec 3.64 s ± 113 ms 3.57 s ± 121 ms -1.96 %
arco-pro_production-mode_persistent-hot + exec 2.2 s ± 61 ms 2.34 s ± 218 ms +6.12 %
arco-pro_production-mode_traverse-chunk-modules + exec 3.59 s ± 114 ms 3.48 s ± 180 ms -3.04 %
large-dyn-imports_development-mode + exec 2.04 s ± 51 ms 1.99 s ± 40 ms -2.67 %
large-dyn-imports_production-mode + exec 2.07 s ± 47 ms 2.04 s ± 178 ms -1.15 %
threejs_development-mode_10x + exec 1.51 s ± 28 ms 1.54 s ± 24 ms +1.93 %
threejs_development-mode_10x_hmr + exec 825 ms ± 14 ms 846 ms ± 15 ms +2.56 %
threejs_production-mode_10x + exec 5.1 s ± 98 ms 5.17 s ± 276 ms +1.35 %
threejs_production-mode_10x_persistent-cold + exec 5.19 s ± 117 ms 5.18 s ± 117 ms -0.10 %
threejs_production-mode_10x_persistent-hot + exec 4.55 s ± 393 ms 4.42 s ± 29 ms -2.77 %
10000_big_production-mode_disable-minimize + rss memory 9687 MiB ± 443 MiB 9464 MiB ± 284 MiB -2.30 %
10000_development-mode + rss memory 658 MiB ± 18 MiB 680 MiB ± 24 MiB +3.48 %
10000_development-mode_hmr + rss memory 845 MiB ± 38 MiB 978 MiB ± 36.5 MiB +15.76 %
10000_production-mode + rss memory 652 MiB ± 37.1 MiB 690 MiB ± 45.3 MiB +5.72 %
10000_production-mode_persistent-cold + rss memory 739 MiB ± 49 MiB 773 MiB ± 40 MiB +4.60 %
10000_production-mode_persistent-hot + rss memory 720 MiB ± 33.1 MiB 745 MiB ± 39.2 MiB +3.52 %
arco-pro_development-mode + rss memory 558 MiB ± 35.9 MiB 573 MiB ± 39.9 MiB +2.70 %
arco-pro_development-mode_hmr + rss memory 495 MiB ± 49.2 MiB 573 MiB ± 40.2 MiB +15.71 %
arco-pro_production-mode + rss memory 696 MiB ± 89.1 MiB 697 MiB ± 66 MiB +0.15 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 707 MiB ± 88.7 MiB 711 MiB ± 53.7 MiB +0.55 %
arco-pro_production-mode_persistent-cold + rss memory 776 MiB ± 85 MiB 750 MiB ± 65.4 MiB -3.40 %
arco-pro_production-mode_persistent-hot + rss memory 621 MiB ± 52.8 MiB 674 MiB ± 108 MiB +8.49 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 707 MiB ± 91.6 MiB 688 MiB ± 105 MiB -2.63 %
large-dyn-imports_development-mode + rss memory 658 MiB ± 9.28 MiB 681 MiB ± 6.77 MiB +3.57 %
large-dyn-imports_production-mode + rss memory 528 MiB ± 4.98 MiB 554 MiB ± 14.9 MiB +4.98 %
threejs_development-mode_10x + rss memory 603 MiB ± 16.2 MiB 615 MiB ± 20.3 MiB +2.03 %
threejs_development-mode_10x_hmr + rss memory 726 MiB ± 21.9 MiB 811 MiB ± 39.5 MiB +11.67 %
threejs_production-mode_10x + rss memory 896 MiB ± 60.5 MiB 931 MiB ± 38.3 MiB +3.82 %
threejs_production-mode_10x_persistent-cold + rss memory 999 MiB ± 83.6 MiB 1033 MiB ± 61 MiB +3.43 %
threejs_production-mode_10x_persistent-hot + rss memory 834 MiB ± 33 MiB 865 MiB ± 49.3 MiB +3.78 %

Threshold exceeded: ["arco-pro_production-mode_persistent-hot + exec"]

@web-infra-dev web-infra-dev deleted a comment from github-actions bot Mar 17, 2025
@SyMind SyMind force-pushed the refactor-js-api-heap branch from 8c9cec2 to d4dc9f8 Compare March 18, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant