Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sidebar always matches "/" #1825

Merged
merged 1 commit into from
Feb 8, 2025
Merged

fix: sidebar always matches "/" #1825

merged 1 commit into from
Feb 8, 2025

Conversation

SoonIter
Copy link
Member

@SoonIter SoonIter commented Feb 7, 2025

Summary

if sidebar has '/', all the sidebar would match the first one, so we need to sort the key first

 {
	'/': [],
	'/guide': [
		{
			text: 'Getting Started',
			link: '/guide/getting-started',
		},
	],
	'/guide/item': []
},

Related Issue

#1780

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@SoonIter SoonIter changed the title fix: sidebar always match "/" fix: sidebar always matches "/" Feb 7, 2025
Copy link

netlify bot commented Feb 7, 2025

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 3c1d92c
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/67a5f48248975100088a2193
😎 Deploy Preview https://deploy-preview-1825--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 79 (🟢 up 8 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SoonIter SoonIter merged commit 920ca42 into main Feb 8, 2025
14 checks passed
@SoonIter SoonIter deleted the fix-algorithm branch February 8, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants