feat: improve some translation options #1995
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request addresses issue #1971 by adding configurable translation options to the
theme-default
package inRspress
. The changes enable dynamic translation for the following components:SidebarMenu/index.tsx
: Replaced hardcoded"Menu"
witht('menuText')
.CopyCodeButton.tsx
: Replaced hardcoded"Copy code"
witht('copyCode')
.code/index.tsx
: Replaced hardcoded"Toggle code wrap"
witht('toggleCodeWrap')
.To support these translations, I added new entries (
menuText
,copyCode
,toggleCodeWrap
) toi18n.json
with default English and Chinese values. TheuseI18n
hook is utilized to dynamically fetch translationsNote:I personally believe the search box width adjustment (to 960px with full-screen below 640px) is not necessary, as the current design appears sufficient
Related Issue
Checklist