Skip to content

feat: update Rsbuild 1.3.18 and set caller name #2139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2025
Merged

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented May 9, 2025

Summary

  • Update Rsbuild to 1.3.18 and set the callerName option of createRsbuild, which can be accessed by Rsbuild plugins through context.callerName, and execute different logic based on this identifier.
  • Unpin @rsbuild/core version.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented May 9, 2025

Deploy Preview for rspress ready!

Name Link
🔨 Latest commit e808860
🔍 Latest deploy log https://app.netlify.com/sites/rspress/deploys/681dba7a794d600008aecb4e
😎 Deploy Preview https://deploy-preview-2139--rspress.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 79 (🔴 down 12 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (🟢 up 9 from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 9, 2025

Deploy Preview for rspress-v2 ready!

Name Link
🔨 Latest commit e808860
🔍 Latest deploy log https://app.netlify.com/sites/rspress-v2/deploys/681dba7a255e090008859437
😎 Deploy Preview https://deploy-preview-2139--rspress-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Timeless0911
Timeless0911 previously approved these changes May 9, 2025
@Timeless0911 Timeless0911 enabled auto-merge (squash) May 9, 2025 08:10
@JounQin
Copy link
Collaborator

JounQin commented May 9, 2025

I'm wondering should we use ~ range for @rsbuild/core just like others?

@chenjiahan chenjiahan disabled auto-merge May 9, 2025 08:17
@chenjiahan
Copy link
Member Author

@JounQin Nice catch, I forgot why we pinned the @rsbuild/core version in the past (maybe we encountered a bug at the time), now unpinning is a better option. I have updated it in this PR.

@SoonIter SoonIter enabled auto-merge (squash) May 9, 2025 08:20
@JounQin
Copy link
Collaborator

JounQin commented May 9, 2025

Actually as a stable version (@rsbuild/* v1+), we should mostly use ^ range at least in the future?

@chenjiahan
Copy link
Member Author

@JounQin We prefer to use ~ to avoid introducing Rspack's experimental features and SWC's Wasm plugins breaking changes to Rspress. see https://rspack.dev/blog/announcing-1-0#does-rspack-follow-semantic-versioning for details.

@SoonIter SoonIter merged commit 9a84258 into main May 9, 2025
12 checks passed
@SoonIter SoonIter deleted the caller_name_0509 branch May 9, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants