Skip to content

Conversation

@SoonIter
Copy link
Member

Summary

test(e2e): playwright support lazyCompilation after Rsbuild 1.4.0, remove RSPRESS_LAZY_COMPILATION=false

Related Issue

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Jun 25, 2025

Deploy Preview for rspress ready!

Name Link
🔨 Latest commit 2cc7b99
🔍 Latest deploy log https://app.netlify.com/projects/rspress/deploys/685bc77bc699c70008c325fe
😎 Deploy Preview https://deploy-preview-2319--rspress.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 78 (🔴 down 18 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (🟢 up 9 from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jun 25, 2025

Deploy Preview for rspress-v2 ready!

Name Link
🔨 Latest commit 28e7a81
🔍 Latest deploy log https://app.netlify.com/projects/rspress-v2/deploys/694259e911083500084c59df
😎 Deploy Preview https://deploy-preview-2319--rspress-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

chenjiahan
chenjiahan previously approved these changes Jun 25, 2025
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chenjiahan chenjiahan enabled auto-merge (squash) June 25, 2025 09:08
Copilot AI review requested due to automatic review settings December 11, 2025 04:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the workaround for playwright's incompatibility with lazy compilation, which is no longer needed after Rsbuild 1.4.0. The changes clean up e2e test configuration by removing the forced disabling of lazy compilation.

  • Removes RSPRESS_LAZY_COMPILATION=false from e2e test environment variables
  • Simplifies the comment explaining the lazy compilation escape hatch

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/core/src/node/initRsbuild.ts Updates comment for lazy compilation configuration, removing outdated playwright reference
e2e/utils/runCommands.ts Removes environment variable that disabled lazy compilation for playwright tests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2025

Rsdoctor Bundle Diff Analysis

📊 Quick Summary (Click to expand)
Project Total Size Change
web 14.9 MB ➡️ 0 B (0.0%)

📁 web

Path: website/doc_build/web/rsdoctor-data.json

📌 Baseline Commit: 2de9231165 | PR: #2898

Metric Current Baseline Change
📊 Total Size 14.9 MB 14.9 MB 0 B (0.0%)
📄 JavaScript 14.3 MB 14.3 MB 0 B (0.0%)
🎨 CSS 114.2 KB 114.2 KB 0 B (0.0%)
🌐 HTML 0 B 0 B N/A
📁 Other Assets 512.5 KB 512.5 KB 0 B (0.0%)

📦 Download Diff Report: web Bundle Diff

Generated by Rsdoctor GitHub Action

Timeless0911
Timeless0911 previously approved these changes Dec 11, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 30 out of 30 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants