Skip to content

fix: dirname not found in import.meta #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
9aoy wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: dirname not found in import.meta #866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
979a5a3
fix: dirname not fount in import.meta
9aoy Jan 14, 2026
6827b0f
fix: update
9aoy Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions e2e/basic/test/meta.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,9 @@
expect(aMetaDirname).toBe(aDirName);
expect(aMetaFileName).toBe(aFileName);
});

it('should get dirname from import meta correctly', async () => {
const { dirname } = import.meta;
expect(dirname).toBe(__dirname);

Check failure on line 36 in e2e/basic/test/meta.test.ts

View workflow job for this annotation

GitHub Actions / e2e (windows-latest, 20)

basic/test/meta.test.ts > import.meta > should get dirname from import meta correctly 

expected 'D%3A/a/rstest/rstest/e2e/basic/test' to be 'D%3A\a\rstest\rstest\e2e\basic\test' // Object.is equality
- Expected
+ Received

- D%3A\a\rstest\rstest\e2e\basic\test
+ D%3A/a/rstest/rstest/e2e/basic/test

Check failure on line 36 in e2e/basic/test/meta.test.ts

View workflow job for this annotation

GitHub Actions / e2e (windows-latest, 18)

basic/test/meta.test.ts > import.meta > should get dirname from import meta correctly 

expected 'D%3A/a/rstest/rstest/e2e/basic/test' to be 'D%3A\a\rstest\rstest\e2e\basic\test' // Object.is equality
- Expected
+ Received

- D%3A\a\rstest\rstest\e2e\basic\test
+ D%3A/a/rstest/rstest/e2e/basic/test

Check failure on line 36 in e2e/basic/test/meta.test.ts

View workflow job for this annotation

GitHub Actions / e2e (windows-latest, 22)

basic/test/meta.test.ts > import.meta > should get dirname from import meta correctly 

expected 'D%3A/a/rstest/rstest/e2e/basic/test' to be 'D%3A\a\rstest\rstest\e2e\basic\test' // Object.is equality
- Expected
+ Received

- D%3A\a\rstest\rstest\e2e\basic\test
+ D%3A/a/rstest/rstest/e2e/basic/test

Check failure on line 36 in e2e/basic/test/meta.test.ts

View workflow job for this annotation

GitHub Actions / e2e (windows-latest, 24)

basic/test/meta.test.ts > import.meta > should get dirname from import meta correctly 

expected 'D%3A/a/rstest/rstest/e2e/basic/test' to be 'D%3A\a\rstest\rstest\e2e\basic\test' // Object.is equality
- Expected
+ Received

- D%3A\a\rstest\rstest\e2e\basic\test
+ D%3A/a/rstest/rstest/e2e/basic/test
});
});
9 changes: 6 additions & 3 deletions packages/core/src/runtime/worker/loadEsModule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,9 +205,12 @@ export const loadModule = async ({
lineOffset: 0,
columnOffset: 0,
initializeImportMeta: (meta) => {
meta.url = pathToFileURL(
distPath.endsWith('rstest-runtime.mjs') ? distPath : testPath,
).toString();
const fileName = distPath.endsWith('rstest-runtime.mjs')
? distPath
: testPath;
meta.url = pathToFileURL(fileName).toString();
meta.dirname = path.dirname(fileName);
meta.filename = fileName;
Comment on lines +212 to +213

Copilot AI Jan 14, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ImportMeta interface in importMeta.d.ts should be updated to include type definitions for the newly added dirname and filename properties. This will provide proper TypeScript support for these properties.

Copilot uses AI. Check for mistakes.
// @ts-expect-error
meta.__rstest_dynamic_import__ = defineRstestDynamicImport({
assetFiles,
Expand Down
Loading