Skip to content

Early customizable select feature #2301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 17, 2025
Merged

Early customizable select feature #2301

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8baf326
Early customizable select feature
captainbrosset Nov 21, 2024
13a888f
Merge branch 'main' of github.com:web-platform-dx/web-features into c…
captainbrosset Jan 30, 2025
d581efd
Update specs.ts to allow OpenUI
captainbrosset Jan 30, 2025
cc27d76
Cleanup yml
captainbrosset Jan 30, 2025
226ebd0
Merge branch 'main' into custom-select
captainbrosset Feb 11, 2025
d835efc
Merge branch 'main' of github.com:web-platform-dx/web-features into c…
captainbrosset Feb 17, 2025
8a3fa33
Merge branch 'main' into custom-select
captainbrosset Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions features/customizable-select.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
name: Customizable <select>
description: The `<select>` element's appearance, including the button, selected option, picker dropdown, and options, can be customized using CSS.
spec: https://open-ui.org/components/customizableselect/
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link should be updated to https://open-ui.org/components/customizableselect/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this the same link that's already there in the file?

group:
- forms
- html-elements
6 changes: 6 additions & 0 deletions features/customizable-select.yml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Generated from: customizable-select.yml
# Do not edit this file by hand. Edit the source file instead!

status:
baseline: false
support: {}
4 changes: 4 additions & 0 deletions scripts/specs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,10 @@ const defaultAllowlist: allowlistItem[] = [
[
"https://github.com/tc39/proposal-import-attributes/tree/abca60286360b47f9a6be25a28f489c2cb157beb",
"Allowed because import assertions were replaced in-place by import attributes. Remove this exception when javascript.statements.import.import_assertions is dropped from BCD in June 2026."
],
[
"https://open-ui.org/components/customizableselect/",
"Allowed because customizable select doesn't yet have a spec URL. And even when it does, it will be defined in multiple HTML, CSS, and ARIA specs. The OpenUI explainer is the only central place that defines the component at the moment."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a good issue or PR to link to that would prompt us to remove this exception? Basically, I want to know where to look when we have "real" spec links to replace this with.

Something like this?

Suggested change
"Allowed because customizable select doesn't yet have a spec URL. And even when it does, it will be defined in multiple HTML, CSS, and ARIA specs. The OpenUI explainer is the only central place that defines the component at the moment."
"Allowed because customizable select doesn't yet have a spec URL. And even when it does, it will be defined in multiple HTML, CSS, and ARIA specs. The OpenUI explainer is the only central place that defines the component at the moment. Remove when SOMEURL merges."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are multiple PRs, not just one. See my previous comment: #2301 (comment)
Out of those, I'm guessing it would be enough to link to the following ones:

whatwg/html#10586
whatwg/html#10629
whatwg/html#10633

@josepharhar are you able to help select one (or more, but ideally a small number) spec PR that would basically signify "that's it, customizable select is now in the spec"?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being slow - if I had to choose one of the PRs, I'd choose the base appearance rendering PR as the best indicator for the spec of customizable select: whatwg/html#10629

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added them all in the meantime 😆
Thank you.

]
];

Expand Down