Skip /third_party/test262/ when computing browser-specific failures#275
Open
yulunwu2 wants to merge 1 commit into
Open
Skip /third_party/test262/ when computing browser-specific failures#275yulunwu2 wants to merge 1 commit into
yulunwu2 wants to merge 1 commit into
Conversation
/third_party/test262/ introduces Temporal tests as individual tests instead of using the subtest WPT convention. These test failtures misrepresent the overal interoperability of the web by causing the single browser failure graph to be completely dominated by a feature not yet shipped by all browsers.
yulunwu2
force-pushed
the
skip-temporal-tests
branch
from
11377ff to
ac68699
Compare
|
No objection to landing this change. However I don't think that continuing to show a metric that's known to be broken is a good long term approach. |
Author
|
@jgraham we could also move/remove the graph. @yulunwu2 created a separate PR for that option. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/third_party/test262/ introduces Temporal tests as individual tests instead of using the subtest WPT convention. These test failures misrepresent the overall interoperability of the web by causing the single browser failure graph to be completely dominated by a feature not yet shipped by all browsers.
The exclusion lives in browser-specific-failures.js so lib/browser-specific.js stays a generic scoring function.